This repository was archived by the owner on Jan 12, 2022. It is now read-only.
Open
Conversation
hrpatel
suggested changes
Oct 26, 2018
mroote
force-pushed
the
feature/mount_theme_directory
branch
from
ce1830d to
c02fc2b
Compare
mroote
changed the title
Contributor
Author
|
@hrpatel have you had a chance to review this yet? |
Contributor
|
You'll need to rebase |
Contributor
|
Lets get this reviewed but wait to merge depending on what happens with the vendor pricing.. it might be a moot point if we decided to go with Virtual Slate |
hrpatel
suggested changes
Nov 8, 2018
| 'd') DETACH='True' ;; | ||
| 't') THEME_DEV='True' ;; | ||
| '?') | ||
| color_echo red "Invalid option: -${OPTARG}" |
|
|
||
| while getopts ":dt" opt; do | ||
| case ${opt} in | ||
| 'd') DETACH='True' ;; |
Contributor
There was a problem hiding this comment.
Make these true or false and use the builtin booleans
| fi | ||
| compose_command="${compose_command} up" | ||
|
|
||
| if [ "${DETACH}" == 'True' ] ; then |
Contributor
There was a problem hiding this comment.
See comment about true/false
| while getopts ":dt" opt; do | ||
| case ${opt} in | ||
| 'd') DETACH='True' ;; | ||
| 't') THEME_DEV='True' ;; |
Contributor
There was a problem hiding this comment.
Same as the other boolean variable
| function stop_moodle { | ||
| local compose_command="${BASE_COMMAND}" | ||
|
|
||
| if [ "${THEME_DEV}" == 'True' ] ; then |
Contributor
There was a problem hiding this comment.
Can probably abstract out this if block into a function and reuse it the other places with the same code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow easier theme development by exposing the theme directory to the host system.